Move metalink files to repo root#581
Conversation
- delete unused *.meta4 files - delete *.meta4 files for unsupported stemcells
|
Warning Rate limit exceeded
Your organization is not enrolled in usage-based pricing. Contact your admin to enable usage-based pricing to continue reviews beyond the rate limit, or try again in 50 minutes and 9 seconds. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Run ID: 📒 Files selected for processing (4)
WalkthroughMultiple metalink XML manifest files under bosh-stemcell/image-metalinks (for ubuntu-bionic, ubuntu-jammy, ubuntu-xenial, ubuntu-noble, and several versioned meta4 files) were deleted, removing file entries, download URLs, sizes, and checksum metadata. CI configuration and build scripts were updated to use a different repo path for metalinks (pointing to bosh-linux-stemcell-builder/image-metalinks), task input Suggested reviewers
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Pull request overview
This PR relocates OS image metalink (*.meta4) files from the bosh-stemcell/ subtree to a repo-root image-metalinks/ directory and removes a set of unused/unsupported metalinks, with corresponding updates to CI task/pipeline paths.
Changes:
- Add the ubuntu-jammy metalink under
image-metalinks/at the new location. - Update the release-metadata task to read the USN metalink from the new repo-root path.
- Update the Concourse builder pipeline metalink-repository resource URI and git
ignore_pathsto reflect the new directory layout; remove legacy/unsupported*.meta4files.
Reviewed changes
Copilot reviewed 13 out of 14 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| image-metalinks/ubuntu-jammy/ubuntu-jammy.meta4 | Adds the jammy metalink in the new repo-root metalinks directory structure. |
| ci/tasks/build-release-metadata.sh | Updates USN metalink path to match the new image-metalinks/ location. |
| ci/pipelines/builder.yml | Updates metalink-repository git URI to point at repo-root image-metalinks/ and adjusts git ignore paths accordingly. |
| bosh-stemcell/image-metalinks/*.meta4 (and subpaths) | Removes legacy metalinks (including unsupported/unused ones) from the old location. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
cf-foundation-community-automation
Bot
moved this to Inbox
in Foundational Infrastructure Working Group
github-project-automation
Bot
moved this from Inbox
to Pending Merge | Prioritized
in Foundational Infrastructure Working Group
github-project-automation
Bot
moved this from Pending Merge | Prioritized
to Waiting for Changes | Open for Contribution
in Foundational Infrastructure Working Group
Remove conditional path in CI that could download the OS_IMAGE using `meta4 file-download`. Remove rake tasks which supported this path, and remove references from docs.
github-project-automation
Bot
moved this from Waiting for Changes | Open for Contribution
to Pending Merge | Prioritized
in Foundational Infrastructure Working Group
aramprice
dismissed stale reviews from selzoc and coderabbitai[bot]
via
1bffe0b
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@README.md`:
- Around line 146-150: Update the README text so the compound modifier is
hyphenated: change occurrences of "stemcell specific tests" (in the description
of the stemcell:build rake task and related lines) to "stemcell-specific tests"
to correctly form the pre-noun modifier; keep surrounding wording intact and
only add the hyphen.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: ASSERTIVE
Plan: Pro
Run ID: d4f364fb-5106-46a0-be52-0023a34f2ff1
📒 Files selected for processing (5)
README.mdRakefileci/tasks/build.shci/tasks/build.ymlci/tasks/os-images/build.sh
💤 Files with no reviewable changes (1)
- ci/tasks/build.yml
github-project-automation
Bot
moved this from Pending Merge | Prioritized
to Waiting for Changes | Open for Contribution
in Foundational Infrastructure Working Group
aramprice
force-pushed
the
metalink-cleanup
branch
from
1bffe0b to
6addedd
Compare
github-project-automation
Bot
moved this from Waiting for Changes | Open for Contribution
to Pending Merge | Prioritized
in Foundational Infrastructure Working Group
github-project-automation
Bot
moved this from Pending Merge | Prioritized
to Done
in Foundational Infrastructure Working Group
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 18 out of 19 changed files in this pull request and generated 2 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| desc 'Build a stemcell, requires `os_image_path` pointing at an image created via `stemcell:build_os_image`' | ||
| task :build, [:infrastructure_name, :hypervisor_name, :operating_system_name, :operating_system_version, :os_image_path, :build_number] do |_, args| |
There was a problem hiding this comment.
stemcell:build now requires os_image_path, but the task doesn’t validate that this argument is present and points to an existing file. Adding an explicit check (and a clear error message) would make failures much easier to diagnose (especially in CI where a missing/empty os-image-tarball input would otherwise surface as less obvious downstream errors).
| the first time you create your docker container**, but every time after, as | ||
| long as you do not destroy the container, you should be able to run the | ||
| specific tests: |
There was a problem hiding this comment.
Minor grammar: “everytime” should be “every time”.
NOTE: requires re-configuring the pipeline!
Next steps:
bosh-stemcell/image-metalinks/ubuntu-noble/ubuntu-noble.meta4->image-metalinks/ubuntu-noble/image-metalinks/ubuntu-jammy/ubuntu-jammy.meta4in both branchesubuntu-jammy/andubuntu-noble/metalinks by dint of the "merge forward" pattern